linux-kernel - Re: [PATCH] ARM: dts: sun8i: s3: pinecube: add ethernet alias for Wi-Fi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <86cfbd41fe80b4936f20925aed0c9010806a0316.camel@aosc.io>
Date:   Wed, 25 Nov 2020 07:30:50 +0800
From:   Icenowy Zheng <icenowy@...c.io>
To:     Maxime Ripard <mripard@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...l.net>
Cc:     devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-sunxi@...glegroups.com
Subject: Re: [PATCH] ARM: dts: sun8i: s3: pinecube: add ethernet alias for
 Wi-Fi

在 2020-11-25星期三的 06:59 +0800，Icenowy Zheng写道：
> The PineCube board has a RTL8189ES Wi-Fi module on board, and the
> module
> doesn't have any MAC address programmed in.

Sorry, but now I'm unsure about this.

The module seems to have MAC address programmed.

> 
> Add a ethernet alias in the DT, thus the bootloader will then be able
> to
> generate a MAC address into the device tree node of Wi-Fi.
> 
> Signed-off-by: Icenowy Zheng <icenowy@...c.io>
> ---
>  arch/arm/boot/dts/sun8i-s3-pinecube.dts | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun8i-s3-pinecube.dts
> b/arch/arm/boot/dts/sun8i-s3-pinecube.dts
> index 4aa0ee897a0a..5086f713467a 100644
> --- a/arch/arm/boot/dts/sun8i-s3-pinecube.dts
> +++ b/arch/arm/boot/dts/sun8i-s3-pinecube.dts
> @@ -13,6 +13,7 @@ / {
>  	compatible = "pine64,pinecube", "sochip,s3", "allwinner,sun8i-
> v3";
>  
>  	aliases {
> +		ethernet0 = &rtl8189es;
>  		serial0 = &uart2;
>  	};
>  
> @@ -156,6 +157,10 @@ &mmc1 {
>  	bus-width = <4>;
>  	non-removable;
>  	status = "okay";
> +
> +	rtl8189es: wifi@1 {
> +		reg = <1>;
> +	};
>  };
>  
>  &pio {