linux-kernel - Re: [PATCH] mmc: sdhci: Use more concise device_property_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2f28f4c7-6f00-33ee-ac38-211c6fb07702@intel.com>
Date:   Wed, 25 Nov 2020 10:08:23 +0200
From:   Adrian Hunter <adrian.hunter@...el.com>
To:     Jeremy Linton <jeremy.linton@....com>, linux-mmc@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, ulf.hansson@...aro.org
Subject: Re: [PATCH] mmc: sdhci: Use more concise device_property_read_u64

On 25/11/20 5:36 am, Jeremy Linton wrote:
> Since we only need a single u64 the _array form is
> unnecessarily. Use device_property_read_u64 instead.
> 
> Signed-off-by: Jeremy Linton <jeremy.linton@....com>

Thank you :-)

Acked-by: Adrian Hunter <adrian.hunter@...el.com>

> ---
>  drivers/mmc/host/sdhci.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index feba64fbde16..ad4ae88a7f74 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -3992,10 +3992,10 @@ void __sdhci_read_caps(struct sdhci_host *host, const u16 *ver,
>  	if (host->v4_mode)
>  		sdhci_do_enable_v4_mode(host);
>  
> -	device_property_read_u64_array(mmc_dev(host->mmc),
> -				       "sdhci-caps-mask", &dt_caps_mask, 1);
> -	device_property_read_u64_array(mmc_dev(host->mmc),
> -				       "sdhci-caps", &dt_caps, 1);
> +	device_property_read_u64(mmc_dev(host->mmc),
> +				 "sdhci-caps-mask", &dt_caps_mask);
> +	device_property_read_u64(mmc_dev(host->mmc),
> +				 "sdhci-caps", &dt_caps);
>  
>  	v = ver ? *ver : sdhci_readw(host, SDHCI_HOST_VERSION);
>  	host->version = (v & SDHCI_SPEC_VER_MASK) >> SDHCI_SPEC_VER_SHIFT;
>