linux-kernel - Re: [RFC 1/2] perf: support build BPF skeletons with perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <05654745-9D53-4D75-BE8E-1B59D7942D3C@fb.com>
Date:   Tue, 24 Nov 2020 23:59:02 +0000
From:   Song Liu <songliubraving@...com>
To:     Jiri Olsa <jolsa@...hat.com>
CC:     open list <linux-kernel@...r.kernel.org>,
        Kernel Team <Kernel-team@...com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "acme@...nel.org" <acme@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "alexander.shishkin@...ux.intel.com" 
        <alexander.shishkin@...ux.intel.com>,
        "namhyung@...nel.org" <namhyung@...nel.org>
Subject: Re: [RFC 1/2] perf: support build BPF skeletons with perf



> On Nov 24, 2020, at 11:51 AM, Jiri Olsa <jolsa@...hat.com> wrote:
> 
> On Wed, Nov 18, 2020 at 08:50:45PM -0800, Song Liu wrote:
> 
> SNIP
> 
>> +
>> +$(TMP_OUTPUT):
>> +	$(call msg,MKDIR,$@)
>> +	$(Q)mkdir -p $(TMP_OUTPUT)
>> +
>> +$(TMP_OUTPUT)/vmlinux.h: $(VMLINUX_BTF_PATH) | $(TMP_OUTPUT) $(BPFTOOL)
>> +	$(call msg,GEN,$@)
>> +	$(Q)if [ ! -e "$(VMLINUX_BTF_PATH)" ] ; then \
>> +		echo "Couldn't find kernel BTF; set VMLINUX_BTF to"	       \
>> +			"specify its location." >&2;			       \
>> +		exit 1;\
>> +	fi
>> +	$(Q)$(BPFTOOL) btf dump file $(VMLINUX_BTF_PATH) format c > $@
>> +
>> +$(BPFOBJ): $(wildcard $(LIBBPF_SRC)/*.[ch] $(LIBBPF_SRC)/Makefile) | $(TMP_OUTPUT)
>> +	$(Q)$(MAKE) $(submake_extras) -C $(LIBBPF_SRC)			       \
>> +		    OUTPUT=$(abspath $(dir $@))/ $(abspath $@)
>> +
>> +$(DEFAULT_BPFTOOL): | $(TMP_OUTPUT)
>> +	$(Q)$(MAKE) $(submake_extras) -C ../../../bpf/bpftool		      \
>> +		    prefix= OUTPUT=$(TMP_OUTPUT)/ DESTDIR=$(TMP_OUTPUT) install
> 
> could we build just the bootstrap version of bpftool?
> should be enough for skeleton and vmlinux.h dump, no?
> 

Yeah, that should work. I thought about it, but didn't try that hard. 

Song