linux-kernel - Re: [PATCH] spi: dw: fixed missing resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 25 Nov 2020 15:14:49 +0300
From:   Serge Semin <fancer.lancer@...il.com>
To:     Tian Tao <tiantao6@...ilicon.com>
Cc:     broonie@...nel.org, linux-spi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: dw: fixed missing resource_size

On Mon, Nov 23, 2020 at 03:02:55PM +0800, Tian Tao wrote:
> fixed the coccicheck:
> drivers/spi/spi-dw-bt1.c:220:27-30: ERROR: Missing
> resource_size with mem.

Thanks, Tian!
Acked-by: Serge Semin <fancer.lancer@...il.com>

> 
> Signed-off-by: Tian Tao <tiantao6@...ilicon.com>
> ---
>  drivers/spi/spi-dw-bt1.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-dw-bt1.c b/drivers/spi/spi-dw-bt1.c
> index f382dfad..da4f4d8 100644
> --- a/drivers/spi/spi-dw-bt1.c
> +++ b/drivers/spi/spi-dw-bt1.c
> @@ -217,7 +217,7 @@ static int dw_spi_bt1_sys_init(struct platform_device *pdev,
>  	if (mem) {
>  		dwsbt1->map = devm_ioremap_resource(&pdev->dev, mem);
>  		if (!IS_ERR(dwsbt1->map)) {
> -			dwsbt1->map_len = (mem->end - mem->start + 1);
> +			dwsbt1->map_len = resource_size(mem);
>  			dws->mem_ops.dirmap_create = dw_spi_bt1_dirmap_create;
>  			dws->mem_ops.dirmap_read = dw_spi_bt1_dirmap_read;
>  		} else {
> -- 
> 2.7.4
>