linux-kernel - Re: [net-next PATCH v5 1/4] net: dsa: mv88e6xxx: Don't force link when using in-band-status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201125003313.GB2075216@lunn.ch>
Date:   Wed, 25 Nov 2020 01:33:13 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Chris Packham <chris.packham@...iedtelesis.co.nz>
Cc:     vivien.didelot@...il.com, f.fainelli@...il.com, olteanv@...il.com,
        davem@...emloft.net, kuba@...nel.org, linux@...linux.org.uk,
        pavana.sharma@...i.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [net-next PATCH v5 1/4] net: dsa: mv88e6xxx: Don't force link
 when using in-band-status

On Tue, Nov 24, 2020 at 05:34:37PM +1300, Chris Packham wrote:
> When a port is configured with 'managed = "in-band-status"' switch chips
> like the 88E6390 need to propagate the SERDES link state to the MAC
> because the link state is not correctly detected. This causes problems
> on the 88E6185/88E6097 where the link partner won't see link state
> changes because we're forcing the link.
> 
> To address this introduce a new device specific op port_sync_link() and
> push the logic from mv88e6xxx_mac_link_up() into that. Provide an
> implementation for the 88E6185 like devices which doesn't force the
> link.
> 
> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew