linux-kernel - Re: [PATCH v2] workqueue: Kick a worker based on the actual activation of delayed works

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <X75R+8CRIOyu1IzE@mtj.duckdns.org>
Date:   Wed, 25 Nov 2020 07:45:47 -0500
From:   Tejun Heo <tj@...nel.org>
To:     Yunfeng Ye <yeyunfeng@...wei.com>
Cc:     jiangshanlai@...il.com, linux-kernel@...r.kernel.org,
        Shiyuan Hu <hushiyuan@...wei.com>,
        Hewenliang <hewenliang4@...wei.com>
Subject: Re: [PATCH v2] workqueue: Kick a worker based on the actual
 activation of delayed works

On Thu, Nov 19, 2020 at 02:21:25PM +0800, Yunfeng Ye wrote:
> In realtime scenario, We do not want to have interference on the
> isolated cpu cores. but when invoking alloc_workqueue() for percpu wq
> on the housekeeping cpu, it kick a kworker on the isolated cpu.
> 
>   alloc_workqueue
>     pwq_adjust_max_active
>       wake_up_worker
> 
> The comment in pwq_adjust_max_active() said:
>   "Need to kick a worker after thawed or an unbound wq's
>    max_active is bumped"
> 
> So it is unnecessary to kick a kworker for percpu's wq when invoking
> alloc_workqueue(). this patch only kick a worker based on the actual
> activation of delayed works.
> 
> Signed-off-by: Yunfeng Ye <yeyunfeng@...wei.com>

Applied to wq/for-5.10-fixes w/ minor comment updates.

Thanks.

-- 
tejun