linux-kernel - Re: [PATCH] fs/kernfs: remove the double check of dentry->inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <X75S00hif93gcd/q@mtj.duckdns.org>
Date:   Wed, 25 Nov 2020 07:49:23 -0500
From:   Tejun Heo <tj@...nel.org>
To:     Hui Su <sh_def@....com>
Cc:     gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs/kernfs: remove the double check of dentry->inode

On Fri, Nov 13, 2020 at 09:21:43PM +0800, Hui Su wrote:
> In both kernfs_node_from_dentry() and in
> kernfs_dentry_node(), we will check the dentry->inode
> is NULL or not, which is superfluous.
> 
> So remove the check in kernfs_node_from_dentry().
> 
> Signed-off-by: Hui Su <sh_def@....com>

Acked-by: Tejun Heo <tj@...nel.org>

Thanks.

-- 
tejun