linux-kernel - Re: [PATCH] microblaze: Remove noMMU code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201125125440.GP8537@kernel.org>
Date:   Wed, 25 Nov 2020 14:54:40 +0200
From:   Mike Rapoport <rppt@...nel.org>
To:     Michal Simek <michal.simek@...inx.com>
Cc:     linux-kernel@...r.kernel.org, monstr@...str.eu, git@...inx.com,
        Arnd Bergmann <arnd@...db.de>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Anshuman Khandual <anshuman.khandual@....com>,
        Arvind Sankar <nivedita@...m.mit.edu>,
        Baoquan He <bhe@...hat.com>,
        Christian Brauner <christian.brauner@...ntu.com>,
        Dmitry Safonov <0x7f454c46@...il.com>,
        Eric Biggers <ebiggers@...gle.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Ira Weiny <ira.weiny@...el.com>, Jens Axboe <axboe@...nel.dk>,
        Joe Perches <joe@...ches.com>,
        Kees Cook <keescook@...omium.org>,
        Manish Narani <manish.narani@...inx.com>,
        Oleg Nesterov <oleg@...hat.com>,
        Pekka Enberg <penberg@...nel.org>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>,
        Randy Dunlap <rdunlap@...radead.org>,
        Rob Herring <robh@...nel.org>,
        Robin Murphy <robin.murphy@....com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Stafford Horne <shorne@...il.com>,
        Stefan Asserhall <stefan.asserhall@...inx.com>,
        "Steven Rostedt (VMware)" <rostedt@...dmis.org>,
        Vlastimil Babka <vbabka@...e.cz>
Subject: Re: [PATCH] microblaze: Remove noMMU code

Hi Michal,

On Wed, Nov 25, 2020 at 01:14:49PM +0100, Michal Simek wrote:
> Hi Mike,
> 
> On 25. 11. 20 13:07, Mike Rapoport wrote:
> > On Wed, Nov 25, 2020 at 12:30:32PM +0100, Michal Simek wrote:
> >> This configuration is obsolete and likely none is really using it. That's
> >> why remove it to simplify code.
> >>
> >> Cc: Arnd Bergmann <arnd@...db.de>
> >> Signed-off-by: Michal Simek <michal.simek@...inx.com>
> >> ---
> > 
> > Looks ok to me except several leftovers:
> > 
> > $ git grep CONFIG_MMU arch/microblaze/
> > arch/microblaze/kernel/hw_exception_handler.S: * STACK FRAME STRUCTURE (for CONFIG_MMU=n)
> > 
> > $ git grep -E 'MICROBLAZE_(64|16)K_PAGES'
> > arch/microblaze/include/asm/page.h:#if defined(CONFIG_MICROBLAZE_64K_PAGES)
> > arch/microblaze/include/asm/page.h:#elif defined(CONFIG_MICROBLAZE_16K_PAGES)
> > arch/microblaze/kernel/hw_exception_handler.S:#ifdef CONFIG_MICROBLAZE_64K_PAGES
> > arch/microblaze/kernel/hw_exception_handler.S:#elif CONFIG_MICROBLAZE_16K_PAGES
> > drivers/net/Kconfig:                 IA64_PAGE_SIZE_64KB || MICROBLAZE_64K_PAGES || \
> > 
> > 
> 
> I left it there intentionally. First one because there is description in
> that comment which references noMMU. If this should be removed the whole
> comment should be tuned to make sense. It is better to do it in separate
> patch.

Makes sense, I just grepped without actually opening the files :)

> And second part. I know I removed that Kconfig macros for it but maybe
> good to talk about what needs to change to support different page size
> for systems with MMU.

I'd add a sentence about it to the changelog.

> Thanks,
> Michal

-- 
Sincerely yours,
Mike.