linux-kernel - Re: [PATCH 062/141] HID: usbhid: Fix fall-through warnings for Clang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2011251402200.3441@cbobk.fhfr.pm>
Date:   Wed, 25 Nov 2020 14:02:28 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     "Gustavo A. R. Silva" <gustavoars@...nel.org>
cc:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-usb@...r.kernel.org, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH 062/141] HID: usbhid: Fix fall-through warnings for
 Clang

On Fri, 20 Nov 2020, Gustavo A. R. Silva wrote:

> In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple
> of warnings by explicitly adding a couple of break statements instead
> of letting the code fall through to the next case.
> 
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org>
> ---
>  drivers/hid/usbhid/hid-core.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c
> index 17a29ee0ac6c..86257ce6d619 100644
> --- a/drivers/hid/usbhid/hid-core.c
> +++ b/drivers/hid/usbhid/hid-core.c
> @@ -438,6 +438,7 @@ static void hid_irq_out(struct urb *urb)
>  		break;
>  	case -ESHUTDOWN:	/* unplug */
>  		unplug = 1;
> +		break;
>  	case -EILSEQ:		/* protocol error or unplug */
>  	case -EPROTO:		/* protocol error or unplug */
>  	case -ECONNRESET:	/* unlink */
> @@ -489,6 +490,7 @@ static void hid_ctrl(struct urb *urb)
>  		break;
>  	case -ESHUTDOWN:	/* unplug */
>  		unplug = 1;
> +		break;
>  	case -EILSEQ:		/* protocol error or unplug */
>  	case -EPROTO:		/* protocol error or unplug */
>  	case -ECONNRESET:	/* unlink */

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs