linux-kernel - Re: [PATCH] HID: wacom: Constify attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 25 Nov 2020 14:18:07 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     Rikard Falkeborn <rikard.falkeborn@...il.com>
cc:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: wacom: Constify attribute_groups

On Wed, 25 Nov 2020, Rikard Falkeborn wrote:

> These are never modified, so make them const to allow the compiler to put
> them in read-only memory. It also allows the compiler to shrink the
> resulting module with ~900 bytes, test-built with gcc 10.2 on x86_64.
> 
>    text    data     bss     dec     hex filename
>  204377   42832     576  247785   3c7e9 drivers/hid/wacom_old.ko
>  204240   42064     576  246880   3c460 drivers/hid/wacom_new.ko

Applied, thanks Rikard.

-- 
Jiri Kosina
SUSE Labs