linux-kernel - Re: [PATCH 22/25] perf buildid-cache: Add support to add build ids from perf data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 25 Nov 2020 15:20:14 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     Jiri Olsa <jolsa@...nel.org>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        lkml <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Ingo Molnar <mingo@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Michael Petlan <mpetlan@...hat.com>,
        Song Liu <songliubraving@...com>,
        Ian Rogers <irogers@...gle.com>,
        Stephane Eranian <eranian@...gle.com>,
        Alexey Budankov <alexey.budankov@...ux.intel.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Adrian Hunter <adrian.hunter@...el.com>
Subject: Re: [PATCH 22/25] perf buildid-cache: Add support to add build ids
 from perf data

On Wed, Nov 25, 2020 at 10:29:11PM +0900, Namhyung Kim wrote:

SNIP

> > +#ifdef HAVE_DEBUGINFOD_SUPPORT
> > +static int call_debuginfod(const char *sbuild_id, char **path, bool debuginfo)
> > +{
> > +       debuginfod_client *c;
> > +       int fd;
> > +
> > +       c = debuginfod_begin();
> > +       if (c == NULL)
> > +               return -1;
> > +
> > +       pr_debug("trying debuginfod for executable <%s> ... ", sbuild_id);
> > +
> > +       if (debuginfo) {
> > +               fd = debuginfod_find_debuginfo(c, (const unsigned char *) sbuild_id,
> > +                                              0, path);
> > +       } else {
> > +               fd = debuginfod_find_executable(c, (const unsigned char *) sbuild_id,
> > +                                               0, path);
> > +       }
> > +       if (fd >= 0)
> > +               close(fd); /* retaining reference by realname */
> > +
> > +       debuginfod_end(c);
> > +       pr_debug("%s%s\n", *path ? "OK " : "FAILED", *path ? *path : "");
> > +       return *path ? 0 : -1;
> > +}
> > +#else
> > +static int call_debuginfod(const char *sbuild_id __maybe_unused,
> > +                          char **path __maybe_unused,
> > +                          bool debuginfo __maybe_unused)
> > +{
> > +       return -1;
> > +}
> > +#endif
> > +
> > +struct dso_store_data {
> > +       bool     hits;
> > +       bool     force_download;
> 
> Where is it set?

it's not, I wanted to add it, but then never needed it,
so it stayed without an option.. I'll remove it

thanks,
jirka