linux-kernel - Re: [PATCH v2] HID: sony: support for ghlive ps3/wii u dongles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 25 Nov 2020 10:06:03 -0500
From:   Pascal Giard <pascal.giard@...mtl.ca>
To:     Jiri Kosina <jikos@...nel.org>
CC:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        <linux-input@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Sanjay Govind <sanjay.govind9@...il.com>
Subject: Re: [PATCH v2] HID: sony: support for ghlive ps3/wii u dongles

Apologies for the resend. I had not realized that gmail's app for
smartphones didn't really support plaintext.

On Wed, Nov 25, 2020 at 8:41 AM Jiri Kosina <jikos@...nel.org> wrote:
>
> On Wed, 25 Nov 2020, Pascal.Giard@...mtl.ca wrote:
>
> > Thank you for reviewing this new version.
> >
> > You are right, we could totally do without GHL_GUITAR_CONTROLLER.
> >
> > This can be seen as premature generalization or an excess of optimism;
> > I'm assuming that the PS4 also needs magic control messages to behave
> > correctly, and that I will figure those sooner than later. But I may be
> > assuming too much and this will be trivial to add when the time comes.
>
> Yeah, let's extend this only when really needed.

Fair.

> > Do you want me to submit a v3?
>
> Please do, thanks. I'll merge that one, I promise :) Sorry for not
> having catched this in v1 already.

No worries, will do.

Thanks again!

-Pascal