linux-kernel - Re: [PATCH] ACPI: processor: Drop duplicate setting of shared_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0ghqXQ_bOYvP7qPDkhyJKseJm5gUJ4hLjLbUE=rRQFx=Q@mail.gmail.com>
Date:   Wed, 25 Nov 2020 16:47:27 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Punit Agrawal <punitagrawal@...il.com>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ACPI: processor: Drop duplicate setting of shared_cpu_map

On Tue, Nov 24, 2020 at 1:00 AM Punit Agrawal <punitagrawal@...il.com> wrote:
>
> 'shared_cpu_map', stored as part of the per-processor
> acpi_processor_performance structre, is used to store cpus that share
> a performance domain. By definition it contains the owning cpu.
>
> While building the 'shared_cpu_map' it is being set twice - once while
> initialising the performance domains and again when matching cpus
> belonging to the same domain.
>
> Drop the unnecessary initialisation.
>
> Signed-off-by: Punit Agrawal <punitagrawal@...il.com>
> ---
>  drivers/acpi/processor_perflib.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/acpi/processor_perflib.c b/drivers/acpi/processor_perflib.c
> index b04a68950ff1..b0d320f18163 100644
> --- a/drivers/acpi/processor_perflib.c
> +++ b/drivers/acpi/processor_perflib.c
> @@ -616,7 +616,6 @@ int acpi_processor_preregister_performance(
>                         continue;
>
>                 pr->performance = per_cpu_ptr(performance, i);
> -               cpumask_set_cpu(i, pr->performance->shared_cpu_map);
>                 pdomain = &(pr->performance->domain_info);
>                 if (acpi_processor_get_psd(pr->handle, pdomain)) {
>                         retval = -EINVAL;
> --

Applied as 5.11 material, thanks!