linux-kernel - Re: [RFC 2/2] perf-stat: enable counting events for BPF programs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 25 Nov 2020 17:43:57 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Song Liu <songliubraving@...com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Kernel Team <Kernel-team@...com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "acme@...nel.org" <acme@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "alexander.shishkin@...ux.intel.com" 
        <alexander.shishkin@...ux.intel.com>,
        "namhyung@...nel.org" <namhyung@...nel.org>
Subject: Re: [RFC 2/2] perf-stat: enable counting events for BPF programs

On Wed, Nov 25, 2020 at 12:02:13AM +0000, Song Liu wrote:
> 
> 
> > On Nov 24, 2020, at 3:43 PM, Song Liu <songliubraving@...com> wrote:
> > 
> > 
> > 
> >> On Nov 24, 2020, at 11:51 AM, Jiri Olsa <jolsa@...hat.com> wrote:
> >> 
> >> On Wed, Nov 18, 2020 at 08:50:46PM -0800, Song Liu wrote:
> >> 
> >> SNIP
> >> 
> >>> +static int bpf_program_profiler__install_pe(struct evsel *evsel, int cpu,
> >>> +					    int fd)
> >>> +{
> >>> +	struct bpf_prog_profiler_bpf *skel = evsel->bpf_counter.skel;
> >>> +
> >>> +	return bpf_map_update_elem(bpf_map__fd(skel->maps.events),
> >>> +				   &cpu, &fd, BPF_ANY);
> >>> +}
> >>> +
> >>> +struct bpf_counter_ops bpf_program_profiler_ops = {
> >>> +	.load       = bpf_program_profiler__load,
> >>> +	.enable	    = bpf_program_profiler__enable,
> >>> +	.read       = bpf_program_profiler__read,
> >>> +	.destroy    = bpf_program_profiler__destroy,
> >>> +	.install_pe = bpf_program_profiler__install_pe,
> >>> +};
> >> 
> >> hum, what's the point of this ops? you plan some other ops?
> >> we could just define stat callbacks right?
> 
> Which callbacks do you mean here? I would like to try that as
> well. 

I meant just to drop that ops struct and have load/enable/read..
functions called from stat code

jirka