linux-kernel - Re: [PATCH v2 1/2] scsi: ufs: Refector ufshcd_setup_clocks() to remove skip_ref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 25 Nov 2020 10:01:05 +0800
From:   hongwus@...eaurora.org
To:     Can Guo <cang@...eaurora.org>
Cc:     Bean Huo <huobean@...il.com>, asutoshd@...eaurora.org,
        nguyenb@...eaurora.org, ziqichen@...eaurora.org,
        rnayak@...eaurora.org, linux-scsi@...r.kernel.org,
        kernel-team@...roid.com, saravanak@...gle.com, salyzyn@...gle.com,
        Alim Akhtar <alim.akhtar@...sung.com>,
        Avri Altman <avri.altman@....com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Tomas Winkler <tomas.winkler@...el.com>,
        Bean Huo <beanhuo@...ron.com>,
        Stanley Chu <stanley.chu@...iatek.com>,
        Bart Van Assche <bvanassche@....org>,
        Satya Tangirala <satyat@...gle.com>,
        open list <linux-kernel@...r.kernel.org>,
        cang=codeaurora.org@...eaurora.org
Subject: Re: [PATCH v2 1/2] scsi: ufs: Refector ufshcd_setup_clocks() to
 remove skip_ref_clk

On 2020-11-25 08:53, Can Guo wrote:
> On 2020-11-25 05:09, Bean Huo wrote:
>> On Mon, 2020-11-23 at 23:28 -0800, Can Guo wrote:
>>> +++ b/drivers/scsi/ufs/ufshcd.h
>>> @@ -229,6 +229,8 @@ struct ufs_dev_cmd {
>>>   * @max_freq: maximum frequency supported by the clock
>>>   * @min_freq: min frequency that can be used for clock scaling
>>>   * @curr_freq: indicates the current frequency that it is set to
>>> + * @always_on_while_link_active: indicate that the clk should not be
>>> disabled if
>>> +                                link is still active
>>>   * @enabled: variable to check against multiple enable/disable
>>>   */
>>>  struct ufs_clk_info {
>>> @@ -238,6 +240,7 @@ struct ufs_clk_info {
>>>         u32 max_freq;
>>>         u32 min_freq;
>>>         u32 curr_freq;
>>> +       bool always_on_while_link_active;
>> 
>> Can,
>> using a sentence as a parameter name looks a little bit clumsy to me.
>> The meaning has been explained in the comments section. How about
>> simplify it and in line with other parameters in the structure?
>> 
> 
> Do you have a better name in mind?
> 
> Thanks,
> 
> Can Guo.
> 
>> Thanks,
>> Bean
>> 
>>>         bool enabled;
>>>  };
>>> 

Looks good to me. The variable name is not a problem.

Reviewed-by: Hongwu Su<hongwus@...eaurora.org>