linux-kernel - Re: drivers/soundwire/qcom.c:767: undefined reference to `slimbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201126042646.GH8403@vkoul-mobl>
Date:   Thu, 26 Nov 2020 09:56:46 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        kernel test robot <lkp@...el.com>,
        Jonathan Marek <jonathan@...ek.ca>, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Bard Liao <yung-chuan.liao@...ux.intel.com>,
        moderated for non-subscribers <alsa-devel@...a-project.org>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
Subject: Re: drivers/soundwire/qcom.c:767: undefined reference to
 `slimbus_bus'

On 25-11-20, 09:31, Randy Dunlap wrote:
> On 11/24/20 9:51 PM, Vinod Koul wrote:

> > From: Vinod Koul <vkoul@...nel.org>
> > Date: Wed, 25 Nov 2020 11:15:22 +0530
> > Subject: [PATCH] soundwire: qcom: Fix build failure when slimbus is module
> > 
> > Commit 5bd773242f75 ("soundwire: qcom: avoid dependency on
> > CONFIG_SLIMBUS") removed hard dependency on Slimbus for qcom driver but
> > it results in build failure when:
> > CONFIG_SOUNDWIRE_QCOM=y
> > CONFIG_SLIMBUS=m
> > 
> > drivers/soundwire/qcom.o: In function `qcom_swrm_probe':
> > qcom.c:(.text+0xf44): undefined reference to `slimbus_bus'
> > 
> > Fix this by using IS_REACHABLE() in driver which is recommended to be
> > sued with imply.
> 
>   used

right

> 
> > 
> > Fixes: 5bd773242f75 ("soundwire: qcom: avoid dependency on CONFIG_SLIMBUS")
> > Reported-by: kernel test robot <lkp@...el.com>
> > Signed-off-by: Vinod Koul <vkoul@...nel.org>
> 
> Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested

Thanks I have added this and Srini's and pushed out now.

-- 
~Vinod