linux-kernel - Re: [PATCH 2/2] arm64: dts: imx8mm-beacon-som: Fix PMIC clock error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201126080708.GB4347@kozik-lap>
Date:   Thu, 26 Nov 2020 09:07:08 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Adam Ford <aford173@...il.com>
Cc:     linux-arm-kernel@...ts.infradead.org, aford@...conembedded.com,
        Rob Herring <robh+dt@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: imx8mm-beacon-som:  Fix PMIC clock error

On Wed, Nov 25, 2020 at 03:03:39PM -0600, Adam Ford wrote:
> The PMIC throws an errors because the clock isn't assigned to it.
> Fix this by assigning the clocks info.
> 
> Fixes:  acb01032e11a ("arm64: defconfig: Enable clock driver for ROHM BD718x7 PMIC")

Hi,

This is not the correct Fixes tag. The defconfig change did not
introduce any bug in DTS. The error message was there before, regardless
of defconfigs. Defconfigs are merely a development or distro aid, not a
definition of working state.

If it really was a bug, then the commit adding DTS is to blame.

Second, I am not sure if there is a bug here to fix - having incomplete
DTS is a bug? Missing device nodes in DTS is a bug?

Also, pay attention to proper white spaces. There is only single
whitespace after ':' and no blank line after entire Fixes tag.

Best regards,
Krzysztof