linux-kernel - Re: [PATCH v3 1/5] genirq/affinity: Add irq_update_affinity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47442f07-4ea2-46ed-59a8-c1fa2857f4c4@huawei.com>
Date:   Thu, 26 Nov 2020 08:54:37 +0000
From:   John Garry <john.garry@...wei.com>
To:     Daniel Wagner <dwagner@...e.de>
CC:     <jejb@...ux.ibm.com>, <martin.petersen@...cle.com>,
        <lenb@...nel.org>, <rjw@...ysocki.net>,
        <gregkh@...uxfoundation.org>, <tglx@...utronix.de>,
        <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linuxarm@...wei.com>, <linux-acpi@...r.kernel.org>,
        <maz@...nel.org>
Subject: Re: [PATCH v3 1/5] genirq/affinity: Add irq_update_affinity_desc()

Hi Daniel,

> 
> On Thu, Nov 26, 2020 at 01:20:37AM +0800, John Garry wrote:
>> +	activated = irqd_is_activated(&desc->irq_data);
>> +	if (activated)
>> +		irq_domain_deactivate_irq(&desc->irq_data);
>> +
>> +	if (affinity->is_managed) {
>> +		irqd_set(&desc->irq_data, IRQD_AFFINITY_MANAGED);
>> +		irqd_set(&desc->irq_data, IRQD_MANAGED_SHUTDOWN);
>> +	}
>> +
>> +	cpumask_copy(desc->irq_common_data.affinity, &affinity->mask);
>> +
>> +	/* Restore the activation state */
>> +	if (activated)
>> +		irq_domain_deactivate_irq(&desc->irq_data);
> Shouldn't this be irq_domain_activate_irq() ?

Yeah, I think so. Blushes.

Cheers,
John