[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <X7+SyTFHOaAchPMo@ulmo>
Date: Thu, 26 Nov 2020 12:34:33 +0100
From: Thierry Reding <thierry.reding@...il.com>
To: Vidya Sagar <vidyas@...dia.com>
Cc: lorenzo.pieralisi@....com, robh+dt@...nel.org, bhelgaas@...gle.com,
jonathanh@...dia.com, amanharitsh123@...il.com,
dinghao.liu@....edu.cn, kw@...ux.com, linux-pci@...r.kernel.org,
linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org,
kthota@...dia.com, mmaddireddy@...dia.com, sagar.tv@...il.com
Subject: Re: [PATCH V4 4/6] PCI: tegra: Continue unconfig sequence even if
parts fail
On Mon, Nov 09, 2020 at 10:49:35PM +0530, Vidya Sagar wrote:
> Currently the driver checks for error value of different APIs during the
> uninitialization sequence. It just returns from there if there is any error
> observed for one of those calls. Comparatively it is better to continue the
> uninitialization sequence irrespective of whether some of them are
> returning error. That way, it is more closer to complete uninitialization.
>
> Signed-off-by: Vidya Sagar <vidyas@...dia.com>
> ---
> V4:
> * None
>
> V3:
> * Modified subject as per Bjorn's suggestion
> * Removed tegra_pcie_init_controller()'s error checking part and pushed
> a separate patch for it
>
> V2:
> * None
>
> drivers/pci/controller/dwc/pcie-tegra194.c | 39 +++++++++-------------
> 1 file changed, 15 insertions(+), 24 deletions(-)
Tested-by: Thierry Reding <treding@...dia.com>
Acked-by: Thierry Reding <treding@...dia.com>
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists