lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 26 Nov 2020 10:37:18 +0000
From:   "Liao, Bard" <bard.liao@...el.com>
To:     Greg KH <gregkh@...uxfoundation.org>,
        Bard Liao <yung-chuan.liao@...ux.intel.com>
CC:     "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "vkoul@...nel.org" <vkoul@...nel.org>,
        "vinod.koul@...aro.org" <vinod.koul@...aro.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "tiwai@...e.de" <tiwai@...e.de>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "jank@...ence.com" <jank@...ence.com>,
        "srinivas.kandagatla@...aro.org" <srinivas.kandagatla@...aro.org>,
        "rander.wang@...ux.intel.com" <rander.wang@...ux.intel.com>,
        "ranjani.sridharan@...ux.intel.com" 
        <ranjani.sridharan@...ux.intel.com>,
        "hui.wang@...onical.com" <hui.wang@...onical.com>,
        "pierre-louis.bossart@...ux.intel.com" 
        <pierre-louis.bossart@...ux.intel.com>,
        "Kale, Sanyog R" <sanyog.r.kale@...el.com>
Subject: RE: [PATCH] regmap: sdw: add required header files



> -----Original Message-----
> From: Greg KH <gregkh@...uxfoundation.org>
> Sent: Thursday, November 26, 2020 1:35 PM
> To: Bard Liao <yung-chuan.liao@...ux.intel.com>
> Cc: alsa-devel@...a-project.org; vkoul@...nel.org; vinod.koul@...aro.org;
> linux-kernel@...r.kernel.org; tiwai@...e.de; broonie@...nel.org;
> jank@...ence.com; srinivas.kandagatla@...aro.org;
> rander.wang@...ux.intel.com; ranjani.sridharan@...ux.intel.com;
> hui.wang@...onical.com; pierre-louis.bossart@...ux.intel.com; Kale, Sanyog
> R <sanyog.r.kale@...el.com>; Liao, Bard <bard.liao@...el.com>
> Subject: Re: [PATCH] regmap: sdw: add required header files
> 
> On Wed, Nov 25, 2020 at 09:01:28PM +0800, Bard Liao wrote:
> > From: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
> >
> > Explicitly add header files used by regmap SoundWire support.
> 
> What is failing to build without this?

I didn't see build errors. But, Documentation/process/submit-checklist.rst
says.
1) If you use a facility then #include the file that defines/declares
   that facility.  Don't depend on other header files pulling in ones
   that you use.

> 
> thanks,
> 
> greg k-h

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ