linux-kernel - Re: [PATCH] parisc: signal: remove _SA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 26 Nov 2020 15:46:23 +0100
From:   Helge Deller <deller@....de>
To:     Anders Roxell <anders.roxell@...aro.org>,
        James.Bottomley@...senPartnership.com
Cc:     linux-parisc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] parisc: signal: remove _SA_SIGGFAULT

On 11/26/20 2:06 PM, Anders Roxell wrote:
> When building tinyconfig on parisc the following error shows up:
>
> /tmp/kernel/signal.c: In function 'do_sigaction':
> /tmp/arch/parisc/include/asm/signal.h:24:30: error: '_SA_SIGGFAULT' undeclared (first use in this function); did you mean 'SIL_FAULT'?
>  #define __ARCH_UAPI_SA_FLAGS _SA_SIGGFAULT
>                               ^~~~~~~~~~~~~
>
> The changes in the two individual patches listed in 'Fixes' below are
> OK.  Remove the _SA_SIGGFAULT define since PH-UX isn't going to be
> supported according to commit 41f5a81c07cd ("parisc: Drop HP-UX specific
> fcntl and signal flags").
>
> Fixes: 23acdc76f179 ("signal: clear non-uapi flag bits when passing/returning sa_flags")
> Fixes: 41f5a81c07cd ("parisc: Drop HP-UX specific fcntl and signal flags")
> Signed-off-by: Anders Roxell <anders.roxell@...aro.org>
> ---
>  arch/parisc/include/asm/signal.h | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/arch/parisc/include/asm/signal.h b/arch/parisc/include/asm/signal.h
> index 30dd1e43ef88..715c96ba2ec8 100644
> --- a/arch/parisc/include/asm/signal.h
> +++ b/arch/parisc/include/asm/signal.h
> @@ -21,8 +21,6 @@ typedef struct {
>  	unsigned long sig[_NSIG_WORDS];
>  } sigset_t;
>
> -#define __ARCH_UAPI_SA_FLAGS	_SA_SIGGFAULT
> -

Which kernel are you testing?
I don't see this line in current git head...?!?

Helge

>  #include <asm/sigcontext.h>
>
>  #endif /* !__ASSEMBLY */
>