linux-kernel - Re: [PATCH net-next 1/3] nfc: s3fwrn5: use signed integer for parsing GPIO numbers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201126170154.GA4978@kozik-lap>
Date:   Thu, 26 Nov 2020 18:01:54 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     bongsu.jeon2@...il.com
Cc:     k.opasiak@...sung.com, linux-nfc@...ts.01.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH net-next 1/3] nfc: s3fwrn5: use signed integer for
 parsing GPIO numbers

On Fri, Nov 27, 2020 at 12:33:37AM +0900, bongsu.jeon2@...il.com wrote:
> From: Krzysztof Kozlowski <krzk@...nel.org>
> 
> GPIOs - as returned by of_get_named_gpio() and used by the gpiolib - are
> signed integers, where negative number indicates error.  The return
> value of of_get_named_gpio() should not be assigned to an unsigned int
> because in case of !CONFIG_GPIOLIB such number would be a valid GPIO.
> 
> Fixes: c04c674fadeb ("nfc: s3fwrn5: Add driver for Samsung S3FWRN5 NFC Chip")
> Cc: <stable@...r.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>

Why do you send my patch?

Best regards,
Krzysztof