linux-kernel - Re: [PATCH] drivers core: export symbols for device hotplug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <X7/kHYpgmRZ6Lwhm@kroah.com>
Date:   Thu, 26 Nov 2020 18:21:33 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Chanho Park <parkch98@...il.com>
Cc:     rafael@...nel.org, linux-kernel@...r.kernel.org,
        Chanho Park <chanho61.park@...sung.com>
Subject: Re: [PATCH] drivers core: export symbols for device hotplug

On Fri, Nov 27, 2020 at 12:01:38AM +0900, Chanho Park wrote:
> To support module build for cpu hotplug driver on type-1 hypervisor
> such as drivers/xen/cpu_hotplug.c, we need to export below four symbols.
> 
> lock_device_hotplug / unlock_device_hotplug
> device_online / device_offline
> 
> Signed-off-by: Chanho Park <chanho61.park@...sung.com>
> ---
>  drivers/base/core.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index d661ada1518f..1bfd0c54a778 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -1586,11 +1586,13 @@ void lock_device_hotplug(void)
>  {
>  	mutex_lock(&device_hotplug_lock);
>  }
> +EXPORT_SYMBOL_GPL(lock_device_hotplug);

Ick, really?  Anyway, where is the follow-on patch that uses this in a
module?  We need that in order to export these otherwise we will just
un-export them with no in-kernel users.

thanks,

greg k-h