linux-kernel - Re: [LKP] Re: [mm/memcg] bd0b230fe1: will-it-scale.per_process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wjvQzJts-5PnFnJcUU5M3ZFv6RSaS01Mchv0unPzh-XVA@mail.gmail.com>
Date:   Thu, 26 Nov 2020 09:39:23 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Feng Tang <feng.tang@...el.com>
Cc:     Michal Hocko <mhocko@...e.com>,
        Xing Zhengjun <zhengjun.xing@...ux.intel.com>,
        Waiman Long <longman@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Shakeel Butt <shakeelb@...gle.com>,
        Chris Down <chris@...isdown.name>,
        Johannes Weiner <hannes@...xchg.org>,
        Roman Gushchin <guro@...com>, Tejun Heo <tj@...nel.org>,
        Vladimir Davydov <vdavydov.dev@...il.com>,
        Yafang Shao <laoar.shao@...il.com>,
        LKML <linux-kernel@...r.kernel.org>, lkp@...ts.01.org,
        kernel test robot <lkp@...el.com>, zhengjun.xing@...el.com,
        "Huang, Ying" <ying.huang@...el.com>, andi.kleen@...el.com
Subject: Re: [LKP] Re: [mm/memcg] bd0b230fe1: will-it-scale.per_process_ops
 -22.7% regression

On Tue, Nov 24, 2020 at 10:24 PM Feng Tang <feng.tang@...el.com> wrote:
>
> And with the following patch to relayout these members, the regression
> is restored and event better. while reducing 64 bytes of sizeof
> 'struct mem_cgroup'

Thanks, applied.

I do wonder if somebody on the hardware side inside Intel might not
perhaps want to look at that load pattern and at why performance
regressed so much. Maybe teach the prefetcher to avoid adjacent cache
lines that end up showing ping-pong behavior..

             Linus