linux-kernel - Re: [PATCH 1/3] arm64: dts: qcom: sc7180: limit IPA iommu streams

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <X7/qIMCOewRMG7Hy@builder.lan>
Date:   Thu, 26 Nov 2020 11:47:12 -0600
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Alex Elder <elder@...aro.org>
Cc:     agross@...nel.org, robh+dt@...nel.org,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] arm64: dts: qcom: sc7180: limit IPA iommu streams

On Wed 25 Nov 19:54 CST 2020, Alex Elder wrote:

> Recently we learned that Android and Windows firmware don't seem to
> like using 3 as an iommu mask value for IPA.  A simple fix was to
> specify exactly the streams needed explicitly, rather than implying
> a range with the mask.  Make the same change for the SC7180 platform.
> 
> See also:
>   https://lore.kernel.org/linux-arm-msm/20201123052305.157686-1-bjorn.andersson@linaro.org/
> 

Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>

> Fixes: d82fade846aa8 ("arm64: dts: qcom: sc7180: add IPA information")
> Signed-off-by: Alex Elder <elder@...aro.org>
> ---
>  arch/arm64/boot/dts/qcom/sc7180.dtsi | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index c0efb101b0d61..eb66aadf360d7 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -1396,7 +1396,8 @@
>  		ipa: ipa@...0000 {
>  			compatible = "qcom,sc7180-ipa";
>  
> -			iommus = <&apps_smmu 0x440 0x3>;
> +			iommus = <&apps_smmu 0x440 0x0>,
> +				 <&apps_smmu 0x442 0x0>;
>  			reg = <0 0x1e40000 0 0x7000>,
>  			      <0 0x1e47000 0 0x2000>,
>  			      <0 0x1e04000 0 0x2c000>;
> -- 
> 2.20.1
>