linux-kernel - Re: [PATCH 19/25] perf tools: Add __perf_session__cache_build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201126175313.GG70905@kernel.org>
Date:   Thu, 26 Nov 2020 14:53:13 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Jiri Olsa <jolsa@...nel.org>
Cc:     lkml <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Ingo Molnar <mingo@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Namhyung Kim <namhyung@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Michael Petlan <mpetlan@...hat.com>,
        Song Liu <songliubraving@...com>,
        Ian Rogers <irogers@...gle.com>,
        Stephane Eranian <eranian@...gle.com>,
        Alexey Budankov <alexey.budankov@...ux.intel.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Adrian Hunter <adrian.hunter@...el.com>
Subject: Re: [PATCH 19/25] perf tools: Add __perf_session__cache_build_ids
 function

Em Thu, Nov 26, 2020 at 06:00:20PM +0100, Jiri Olsa escreveu:
> Adding __perf_session__cache_build_ids function as an
> interface for caching sessions build ids with callback
> function and its data pointer.

Thanks, applied.

- Arnaldo

 
> Signed-off-by: Jiri Olsa <jolsa@...nel.org>
> ---
>  tools/perf/util/build-id.c | 10 ++++++++--
>  tools/perf/util/build-id.h |  3 +++
>  2 files changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/util/build-id.c b/tools/perf/util/build-id.c
> index 948a7f48d668..6bf3cc79c5d5 100644
> --- a/tools/perf/util/build-id.c
> +++ b/tools/perf/util/build-id.c
> @@ -892,7 +892,8 @@ machines__for_each_dso(struct machines *machines, machine__dso_t fn, void *priv)
>  	return ret ? -1 : 0;
>  }
>  
> -int perf_session__cache_build_ids(struct perf_session *session)
> +int __perf_session__cache_build_ids(struct perf_session *session,
> +				    machine__dso_t fn, void *priv)
>  {
>  	if (no_buildid_cache)
>  		return 0;
> @@ -900,7 +901,12 @@ int perf_session__cache_build_ids(struct perf_session *session)
>  	if (mkdir(buildid_dir, 0755) != 0 && errno != EEXIST)
>  		return -1;
>  
> -	return machines__for_each_dso(&session->machines, dso__cache_build_id, NULL) ?  -1 : 0;
> +	return machines__for_each_dso(&session->machines, fn, priv) ?  -1 : 0;
> +}
> +
> +int perf_session__cache_build_ids(struct perf_session *session)
> +{
> +	return __perf_session__cache_build_ids(session, dso__cache_build_id, NULL);
>  }
>  
>  static bool machine__read_build_ids(struct machine *machine, bool with_hits)
> diff --git a/tools/perf/util/build-id.h b/tools/perf/util/build-id.h
> index f1a2f67df6e4..c6f10e3d2152 100644
> --- a/tools/perf/util/build-id.h
> +++ b/tools/perf/util/build-id.h
> @@ -5,6 +5,7 @@
>  #define BUILD_ID_SIZE	20
>  #define SBUILD_ID_SIZE	(BUILD_ID_SIZE * 2 + 1)
>  
> +#include "machine.h"
>  #include "tool.h"
>  #include <linux/types.h>
>  
> @@ -46,6 +47,8 @@ bool perf_session__read_build_ids(struct perf_session *session, bool with_hits);
>  int perf_session__write_buildid_table(struct perf_session *session,
>  				      struct feat_fd *fd);
>  int perf_session__cache_build_ids(struct perf_session *session);
> +int __perf_session__cache_build_ids(struct perf_session *session,
> +				    machine__dso_t fn, void *priv);
>  
>  char *build_id_cache__origname(const char *sbuild_id);
>  char *build_id_cache__linkname(const char *sbuild_id, char *bf, size_t size);
> -- 
> 2.26.2
> 

-- 

- Arnaldo