linux-kernel - Re: [PATCH -next] perf util: Fix memory leak in __parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0e52c7be-ca81-2f4d-ee2f-8f9ced382f60@huawei.com>
Date:   Fri, 27 Nov 2020 15:45:40 +0800
From:   Zheng Zengkai <zhengzengkai@...wei.com>
To:     Jiri Olsa <jolsa@...hat.com>
CC:     <acme@...nel.org>, <mark.rutland@....com>,
        <alexander.shishkin@...ux.intel.com>, <namhyung@...nel.org>,
        <linux-kernel@...r.kernel.org>, <huawei.libin@...wei.com>
Subject: Re: [PATCH -next] perf util: Fix memory leak in __parse_regs()

Ping...

> On Fri, Jul 03, 2020 at 05:33:44PM +0800, Zheng Zengkai wrote:
>> when using perf record option '-I' or '--user-regs='
>> along with argument '?' to list available register names,
>> memory of variable 'os' allocated by strdup() needs to be released
>> before __parse_regs() returns, otherwise memory leak will occur.
>>
>> Fixes: bcc84ec65ad1 ("perf record: Add ability to name registers to record")
>> Signed-off-by: Zheng Zengkai <zhengzengkai@...wei.com>
> Acked-by: Jiri Olsa <jolsa@...hat.com>
>
> thanks,
> jirka
>
>> ---
>>   tools/perf/util/parse-regs-options.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/perf/util/parse-regs-options.c b/tools/perf/util/parse-regs-options.c
>> index e687497b3aac..a4a100425b3a 100644
>> --- a/tools/perf/util/parse-regs-options.c
>> +++ b/tools/perf/util/parse-regs-options.c
>> @@ -54,7 +54,7 @@ __parse_regs(const struct option *opt, const char *str, int unset, bool intr)
>>   #endif
>>   				fputc('\n', stderr);
>>   				/* just printing available regs */
>> -				return -1;
>> +				goto error;
>>   			}
>>   #ifdef HAVE_PERF_REGS_SUPPORT
>>   			for (r = sample_reg_masks; r->name; r++) {
>> -- 
>> 2.20.1
>>
> .
>