linux-kernel - RE: [PATCH] usb: cdns3: Fix hardware based role switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 27 Nov 2020 09:47:53 +0000
From:   Peter Chen <peter.chen@....com>
To:     Roger Quadros <rogerq@...com>,
        "pawell@...ence.com" <pawell@...ence.com>
CC:     "heikki.krogerus@...ux.intel.com" <heikki.krogerus@...ux.intel.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "balbi@...nel.org" <balbi@...nel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] usb: cdns3: Fix hardware based role switch

 
> Hi Peter,
> 
> On 25/11/2020 14:49, Roger Quadros wrote:
> > Hardware based role switch is broken as the driver always skips it.
> > Fix this by registering for  SW role switch only if 'usb-role-switch'
> > property is present in the device tree.
> >
> > Fixes: 50642709f659 ("usb: cdns3: core: quit if it uses role switch
> > class")
> > Signed-off-by: Roger Quadros <rogerq@...com>
> 
> Can you please pick this up for -rc cycle, else otg will be broken for us in v5.10
> release.
> Thanks.
> 

It is at my -fixes tree along with my two fixes[1][2]. If there is no report issue,
I will send it to Greg next Monday.

[1] https://patchwork.kernel.org/project/linux-usb/patch/20201126065409.7533-1-peter.chen@kernel.org/
[2] https://patchwork.kernel.org/project/linux-usb/patch/20201126065409.7533-2-peter.chen@kernel.org/

Peter