linux-kernel - Re: [PATCH] printk: finalize records with trailing newlines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <X8DzctH5tYpM2/sd@alley>
Date:   Fri, 27 Nov 2020 13:39:14 +0100
From:   Petr Mladek <pmladek@...e.com>
To:     Kefeng Wang <wangkefeng.wang@...wei.com>
Cc:     John Ogness <john.ogness@...utronix.de>,
        Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Atish Patra <atishp@...shpatra.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] printk: finalize records with trailing newlines

On Thu 2020-11-26 20:32:18, Kefeng Wang wrote:
> 
> On 2020/11/26 19:48, John Ogness wrote:
> > Any record with a trailing newline (LOG_NEWLINE flag) cannot
> > be continued because the newline has been stripped and will
> > not be visible if the message is appended. This was already
> > handled correctly when committing in log_output() but was
> > not handled correctly when committing in log_store().
> > 
> > Fixes: f5f022e53b87 ("printk: reimplement log_cont using record extension")
> > Signed-off-by: John Ogness <john.ogness@...utronix.de>
> > ---
> >   This is an important bugfix for continuous messages and should
> >   be part of the 5.10 release.
> > 
> >   If not applied, newlines will vanish when concatenating
> >   continuous with trailing newlines.
> Thanks for you quick fix.
> 
> Reported-and-tested-by:  Kefeng Wang <wangkefeng.wang@...wei.com>

The patch is committed in printk/linux.git, branch
for-5.10-pr_cont-fixup.

I do not have much experience with pushing fixes this late in the
release cycle.

Normally, I would prefer to give it few days in linux-next. But
the fix is quite trivial. And it would be better to have it
in 10-rc6 rather than in rc7 that might be the last rc before
release.

Thanks a lot for report, fix, and testing.

Best Regards,
Petr