linux-kernel - Re: [PATCH] drivers: gpio: use of_match_ptr() and ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 27 Nov 2020 13:45:17 +0100
From:   "Enrico Weigelt, metux IT consult" <lkml@...ux.net>
To:     Andy Shevchenko <andy.shevchenko@...il.com>,
        Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc:     "Enrico Weigelt, metux IT consult" <info@...ux.net>,
        Jonathan Cameron <jic23@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-tegra@...r.kernel.org,
        Thierry Reding <thierry.reding@...il.com>,
        Alban Bedel <albeu@...e.fr>,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        Lee Jones <lee.jones@...aro.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Kevin Hilman <khilman@...nel.org>, zhang.lyra@...il.com,
        Marek Behún <marek.behun@....cz>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>,
        dl-linux-imx <linux-imx@....com>, orsonzhai@...il.com,
        Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>,
        linux-pwm@...r.kernel.org,
        Grygorii Strashko <grygorii.strashko@...com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Vladimir Zapolskiy <vz@...ia.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Fabio Estevam <festevam@...il.com>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Linux OMAP Mailing List <linux-omap@...r.kernel.org>,
        Hoan Tran <hoan@...amperecomputing.com>,
        Scott Branden <sbranden@...adcom.com>,
        Andrew Jeffery <andrew@...id.au>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Serge Semin <fancer.lancer@...il.com>,
        Sascha Hauer <kernel@...gutronix.de>, baolin.wang7@...il.com,
        Shawn Guo <shawnguo@...nel.org>
Subject: Re: [PATCH] drivers: gpio: use of_match_ptr() and ACPI_PTR() macros

On 18.11.20 11:01, Andy Shevchenko wrote:

>>> So a system without CONFIG_OF might still make use of .of_match_table?
>>
>> Yep!
> 
> If you are curious:
> https://elixir.bootlin.com/linux/latest/source/drivers/acpi/bus.c#L615

Phuh, this changes everything ... sorry, didn't know that.

If ACPI now can contain OF pieces, we should ask the question whether
of_match_ptr() should be used at all.

Would it be a compromise introducing a new macro (eg. "OF_MATCH_PTR()")
which passes through the pointer if either OF or ACPI is enabled.
Maybe we could introduce a new config item (eg "OF_MATCH_TABLE") for
that, which is enabled by both OF and ACPI. And maybe add an option for
of-compatible checking in ACPI.

How do you folks think about that ?


--mtx

-- 
---
Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert
werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren
GPG/PGP-Schlüssel zu.
---
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@...ux.net -- +49-151-27565287