linux-kernel - Re: [PATCH v2 1/3] genirq/affinity: Add irq_update_affinity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6f3e8b84867936a8301fc3ec62533df9@kernel.org>
Date:   Fri, 27 Nov 2020 12:49:33 +0000
From:   Marc Zyngier <maz@...nel.org>
To:     John Garry <john.garry@...wei.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>, gregkh@...uxfoundation.org,
        rafael@...nel.org, martin.petersen@...cle.com, jejb@...ux.ibm.com,
        linuxarm@...wei.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] genirq/affinity: Add irq_update_affinity_desc()

On 2020-11-27 12:45, John Garry wrote:
> On 27/11/2020 09:57, Marc Zyngier wrote:
>>> If I understand the code correctly, MSI_ALLOC_FLAGS_SHARED_DEVICE is
>>> supposed to be set in info->flags in platform_msi_set_desc(), but 
>>> this
>>> is called per-msi after its_msi_prepare(), so we don't the flags set
>>> at the right time. That's how it looks to me...
>> 
>> Meh. I was trying multiple things, and of course commited the worse
>> possible approach.
>> 
>> I've updated the branch, having verified that we do get the flag in
>> the ITS now.
> 
> Hi Marc,
> 
> That looks to work.

Thanks for having given it a go.

> So do you have an upstream plan for this? I ask, as if you go with
> this, then I may change my series to map and unmap all the irqs again
> - but not sure about that.

I'll write some commit messages, and post that. Either this weekend,
or on Monday at the latest.

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...