linux-kernel - Re: [PATCH 1/1] perf diff: fix error return value in __cmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM9d7cgKDMCst2jEmHMHT7MC0DaTg1naNTt3cZnRepiNkmF-VA@mail.gmail.com>
Date:   Fri, 27 Nov 2020 22:35:37 +0900
From:   Namhyung Kim <namhyung@...nel.org>
To:     Zhen Lei <thunder.leizhen@...wei.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] perf diff: fix error return value in __cmd_diff()

Hello,

On Tue, Nov 24, 2020 at 7:37 PM Zhen Lei <thunder.leizhen@...wei.com> wrote:
>
> An appropriate return value should be set on the failed path.
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@...wei.com>

Acked-by: Namhyung Kim <namhyung@...nel.org>

Thanks,
Namhyung

> ---
>  tools/perf/builtin-diff.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
> index 584e2e1a3793..cefc71506409 100644
> --- a/tools/perf/builtin-diff.c
> +++ b/tools/perf/builtin-diff.c
> @@ -1222,8 +1222,10 @@ static int __cmd_diff(void)
>                 if (compute == COMPUTE_STREAM) {
>                         d->evlist_streams = evlist__create_streams(
>                                                 d->session->evlist, 5);
> -                       if (!d->evlist_streams)
> +                       if (!d->evlist_streams) {
> +                               ret = -ENOMEM;
>                                 goto out_delete;
> +                       }
>                 }
>         }
>
> --
> 2.26.0.106.g9fadedd
>
>