linux-kernel - Re: [PATCH v3 2/3] spi: Add SPI_NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 27 Nov 2020 16:23:40 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Alexandru Ardelean <alexandru.ardelean@...log.com>
Cc:     linux-spi <linux-spi@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Brown <broonie@...nel.org>,
        "Bogdan, Dragos" <dragos.bogdan@...log.com>
Subject: Re: [PATCH v3 2/3] spi: Add SPI_NO_TX/RX support

On Fri, Nov 27, 2020 at 4:22 PM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
> On Fri, Nov 27, 2020 at 3:08 PM Alexandru Ardelean
> <alexandru.ardelean@...log.com> wrote:

...

> > --- a/include/uapi/linux/spi/spi.h
> > +++ b/include/uapi/linux/spi/spi.h
> > @@ -43,5 +43,7 @@
> >  #define        SPI_TX_OCTAL            0x2000          /* transmit with 8 wires */
> >  #define        SPI_RX_OCTAL            0x4000          /* receive with 8 wires */
> >  #define        SPI_3WIRE_HIZ           0x8000          /* high impedance turnaround */
> > +#define        SPI_NO_TX               0x10000         /* no transmit wire */
> > +#define        SPI_NO_RX               0x20000         /* no receive wire */
>
> Is it really material for uAPI?
> Perhaps we may have something like
> SPI_MODE_USER_MASK in uAPI and
> in internal headers
>
> SPI_MODE_KERNEL_MASK with
> static_assert(_USER_MASK & _KERNEL_MASK); // check conditional
>
> ?

And logically start bits for the kernel from the end (31, 30, ...).

-- 
With Best Regards,
Andy Shevchenko