[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <160649557681.2744658.2307630527176652528.stgit@warthog.procyon.org.uk>
Date: Fri, 27 Nov 2020 16:46:16 +0000
From: David Howells <dhowells@...hat.com>
To: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
Cc: Tom Rix <trix@...hat.com>, dhowells@...hat.com,
keyrings@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH 7/9] KEYS: remove redundant memset
From: Tom Rix <trix@...hat.com>
Reviewing use of memset in keyctrl_pkey.c
keyctl_pkey_params_get prologue code to set params up
memset(params, 0, sizeof(*params));
params->encoding = "raw";
keyctl_pkey_query has the same prologue
and calls keyctl_pkey_params_get.
So remove the prologue.
Signed-off-by: Tom Rix <trix@...hat.com>
Signed-off-by: David Howells <dhowells@...hat.com>
---
security/keys/keyctl_pkey.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/security/keys/keyctl_pkey.c b/security/keys/keyctl_pkey.c
index 931d8dfb4a7f..5de0d599a274 100644
--- a/security/keys/keyctl_pkey.c
+++ b/security/keys/keyctl_pkey.c
@@ -166,8 +166,6 @@ long keyctl_pkey_query(key_serial_t id,
struct kernel_pkey_query res;
long ret;
- memset(¶ms, 0, sizeof(params));
-
ret = keyctl_pkey_params_get(id, _info, ¶ms);
if (ret < 0)
goto error;
Powered by blists - more mailing lists