lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 27 Nov 2020 14:25:44 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Zhen Lei <thunder.leizhen@...wei.com>
Cc:     Jin Yao <yao.jin@...ux.intel.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] perf diff: fix error return value in __cmd_diff()

Em Fri, Nov 27, 2020 at 02:22:02PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Nov 27, 2020 at 10:35:37PM +0900, Namhyung Kim escreveu:
> > On Tue, Nov 24, 2020 at 7:37 PM Zhen Lei <thunder.leizhen@...wei.com> wrote:

> > > An appropriate return value should be set on the failed path.

> > > Reported-by: Hulk Robot <hulkci@...wei.com>
> > > Signed-off-by: Zhen Lei <thunder.leizhen@...wei.com>
 
> > Acked-by: Namhyung Kim <namhyung@...nel.org>
 
> Thanks, applied.

I also added this:

Cc: Jin Yao <yao.jin@...ux.intel.com>
Fixes: 2a09a84c720b436a ("perf diff: Support hot streams comparison")

Please add the fixes line and CC the author of the patch introducing the
bug next time,

Thanks

- Arnaldo

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ