linux-kernel - Re: [PATCH] [SCSI] sym53c8xx: remove trailing semicolon in macro definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <841ba4da542c338281eab9f335bbf496cb6b3f69.camel@linux.ibm.com>
Date:   Fri, 27 Nov 2020 10:37:45 -0800
From:   James Bottomley <jejb@...ux.ibm.com>
To:     trix@...hat.com, willy@...radead.org, martin.petersen@...cle.com
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [SCSI] sym53c8xx: remove trailing semicolon in macro
 definition

On Fri, 2020-11-27 at 10:29 -0800, trix@...hat.com wrote:
> From: Tom Rix <trix@...hat.com>
> 
> The macro use will already have a semicolon.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>  drivers/scsi/sym53c8xx_2/sym_glue.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/sym53c8xx_2/sym_glue.c
> b/drivers/scsi/sym53c8xx_2/sym_glue.c
> index d9a045f9858c..f3b3345c1766 100644
> --- a/drivers/scsi/sym53c8xx_2/sym_glue.c
> +++ b/drivers/scsi/sym53c8xx_2/sym_glue.c
> @@ -1001,12 +1001,12 @@ static int is_keyword(char *ptr, int len,
> char *verb)
>  #define SKIP_SPACES(ptr, len)					
> 	\
>  	if ((arg_len = sym_skip_spaces(ptr, len)) < 1)			
> \
>  		return -EINVAL;						
> \
> -	ptr += arg_len; len -= arg_len;
> +	ptr += arg_len; len -= arg_len
>  
>  #define GET_INT_ARG(ptr, len, v)					
> \
>  	if (!(arg_len = get_int_arg(ptr, len, &(v))))			
> \
>  		return -EINVAL;						
> \
> -	ptr += arg_len; len -= arg_len;
> +	ptr += arg_len; len -= arg_len

Those macros have the wrong form which can lead to actual bugs and this
cosmetic change does nothing to fix it.  If the goal here is to get the
code base into better shape, please fix the bugs.

James