linux-kernel - Re: [REGRESSION] omapdrm/N900 display broken

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 27 Nov 2020 20:44:23 +0200
From:   Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>
To:     Tomi Valkeinen <tomi.valkeinen@...com>
Cc:     Aaro Koskinen <aaro.koskinen@....fi>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        ML dri-devel <dri-devel@...ts.freedesktop.org>,
        Tony Lindgren <tony@...mide.com>, linux-omap@...r.kernel.org,
        linux-kernel@...r.kernel.org, Sebastian Reichel <sre@...nel.org>
Subject: Re: [REGRESSION] omapdrm/N900 display broken

Hi,

On 27.11.20 г. 19:30 ч., Tomi Valkeinen wrote:
> On 27/11/2020 17:37, Ivaylo Dimitrov wrote:
> 
>> With 5.9.11 and the patch on top, n900 boots fine, albeit display remains blank, could be related to
>> brightness, we're still investigating.
> 
> Ok. A DSS regdump for a working version and the latest one would be good too. There's a omapdss
> debugfs dir, with dss, dispc and clk files which are of interest here.
> 

It turned out to be a long standing bug in the panel driver, with the 
bellow fix it works fine:


diff --git a/drivers/gpu/drm/panel/panel-sony-acx565akm.c 
b/drivers/gpu/drm/panel/panel-sony-acx565akm.c
index fc6a7e451abe..304267f7849a
--- a/drivers/gpu/drm/panel/panel-sony-acx565akm.c
+++ b/drivers/gpu/drm/panel/panel-sony-acx565akm.c
@@ -629,7 +629,7 @@ static int acx565akm_probe(struct spi_device *spi)
         lcd->spi = spi;
         mutex_init(&lcd->mutex);

-       lcd->reset_gpio = devm_gpiod_get(&spi->dev, "reset", GPIOD_OUT_LOW);
+       lcd->reset_gpio = devm_gpiod_get(&spi->dev, "reset", 
GPIOD_OUT_HIGH);
         if (IS_ERR(lcd->reset_gpio)) {
                 dev_err(&spi->dev, "failed to get reset GPIO\n");
                 return PTR_ERR(lcd->reset_gpio);

Proper patch will follow.

Thanks,
Ivo