[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20201127223803.GA19743@duo.ucw.cz>
Date: Fri, 27 Nov 2020 23:38:03 +0100
From: Pavel Machek <pavel@...x.de>
To: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Cc: Sergei Shtylyov <sergei.shtylyov@...il.com>,
Krzysztof Kozlowski <krzk@...nel.org>,
Philipp Zabel <p.zabel@...gutronix.de>,
Jiri Kosina <trivial@...nel.org>,
Mark Brown <broonie@...nel.org>,
linux-renesas-soc@...r.kernel.org, Pavel Machek <pavel@...x.de>,
Geert Uytterhoeven <geert+renesas@...der.be>,
linux-kernel@...r.kernel.org,
Prabhakar <prabhakar.csengg@...il.com>, stable@...r.kernel.org
Subject: Re: [PATCH v2 1/5] memory: renesas-rpc-if: Return correct value to
the caller of rpcif_manual_xfer()
On Thu 2020-11-26 19:11:42, Lad Prabhakar wrote:
> In the error path of rpcif_manual_xfer() the value of ret is overwritten
> by value returned by reset_control_reset() function and thus returning
> incorrect value to the caller.
>
> This patch makes sure the correct value is returned to the caller of
> rpcif_manual_xfer() by dropping the overwrite of ret in error path.
> Also now we ignore the value returned by reset_control_reset() in the
> error path and instead print a error message when it fails.
>
> Fixes: ca7d8b980b67f ("memory: add Renesas RPC-IF driver")
> Reported-by: Pavel Machek <pavel@...x.de>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> Cc: stable@...r.kernel.org
> Reviewed-by: Sergei Shtylyov <sergei.shtylyov@...il.com>
Reviewed-by: Pavel Machek (CIP) <pavel@...x.de>
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)
Powered by blists - more mailing lists