linux-kernel - Re: [PATCH] NFC:Fix Warning: Comparison to bool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201127145951.703183d0@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
Date:   Fri, 27 Nov 2020 14:59:51 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Runzhe Wang <xia1@...ux.alibaba.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] NFC:Fix Warning: Comparison to bool

On Thu, 26 Nov 2020 15:15:42 +0800 Runzhe Wang wrote:
> This patch uses the shdlc->rnr variable as a judgment condition of
> statement, rather than compares with bool.
> 
> Signed-off-by: Runzhe Wang <xia1@...ux.alibaba.com>
> Reported-by: Abaci <abaci@...ux.alibaba.com>

"Fix Warning" sounds like you're addressing a real compiler warning,
please use a more suitable subject if the warning in question is from
your own tool. Like "nfc: refactor unnecessary comparison to bool".

> diff --git a/net/nfc/hci/llc_shdlc.c b/net/nfc/hci/llc_shdlc.c
> index 0eb4ddc..f178a42 100644
> --- a/net/nfc/hci/llc_shdlc.c
> +++ b/net/nfc/hci/llc_shdlc.c
> @@ -319,7 +319,7 @@ static void llc_shdlc_rcv_s_frame(struct llc_shdlc *shdlc,
>  	switch (s_frame_type) {
>  	case S_FRAME_RR:
>  		llc_shdlc_rcv_ack(shdlc, nr);
> -		if (shdlc->rnr == true) {	/* see SHDLC 10.7.7 */
> +		if (shdlc->rnr) {	/* see SHDLC 10.7.7 */

rnr is a bool, this is perfectly legal, there are also comparisons to
false which you don't fix, and nobody has touched this driver in 8
years so polishing this code is not exactly worth the effort.

I'm not applying this patch, sorry.

>  			shdlc->rnr = false;
>  			if (shdlc->send_q.qlen == 0) {
>  				skb = llc_shdlc_alloc_skb(shdlc, 0);