linux-kernel - [PATCH] proc: add locking checks in proc_inode_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 29 Nov 2020 01:58:50 +0800
From:   Wen Yang <wenyang@...ux.alibaba.com>
To:     Alexey Dobriyan <adobriyan@...il.com>,
        Christian Brauner <christian@...uner.io>, ebiederm@...ssion.com
Cc:     Wen Yang <wenyang@...ux.alibaba.com>,
        Oleg Nesterov <oleg@...hat.com>, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org
Subject: [PATCH] proc: add locking checks in proc_inode_is_dead

The proc_inode_is_dead function might race with __unhash_process.
This will result in a whole bunch of stale proc entries being cached.
To prevent that, add the required locking.

Signed-off-by: Wen Yang <wenyang@...ux.alibaba.com>
Cc: Oleg Nesterov <oleg@...hat.com>
Cc: "Eric W. Biederman" <ebiederm@...ssion.com>
Cc: Alexey Dobriyan <adobriyan@...il.com>
Cc: Christian Brauner <christian@...uner.io>
Cc: linux-kernel@...r.kernel.org
Cc: linux-fsdevel@...r.kernel.org
---
 fs/proc/base.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/fs/proc/base.c b/fs/proc/base.c
index 1bc9bcd..59720bc 100644
--- a/fs/proc/base.c
+++ b/fs/proc/base.c
@@ -1994,7 +1994,13 @@ static int pid_revalidate(struct dentry *dentry, unsigned int flags)
 
 static inline bool proc_inode_is_dead(struct inode *inode)
 {
-	return !proc_pid(inode)->tasks[PIDTYPE_PID].first;
+	bool has_task;
+
+	read_lock(&tasklist_lock);
+	has_task = pid_has_task(proc_pid(inode), PIDTYPE_PID);
+	read_unlock(&tasklist_lock);
+
+	return !has_task;
 }
 
 int pid_delete_dentry(const struct dentry *dentry)
-- 
1.8.3.1