linux-kernel - Re: [PATCH] nfsd: Fix kernel test robot warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <F1972C21-8C1A-4B93-868F-2B849D224D0C@oracle.com>
Date:   Sat, 28 Nov 2020 13:41:23 -0500
From:   Chuck Lever <chuck.lever@...cle.com>
To:     Souptick Joarder <jrdr.linux@...il.com>
Cc:     Bruce Fields <bfields@...ldses.org>,
        Linux NFS Mailing List <linux-nfs@...r.kernel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nfsd: Fix kernel test robot warning

Hello Souptick-

This looks like the same error that Coverity caught earlier this
week. AFAIK Bruce intends to address this issue with a replacement
patch:

https://lore.kernel.org/linux-nfs/20201125164738.GA7049@fieldses.org/


> On Nov 28, 2020, at 8:50 AM, Souptick Joarder <jrdr.linux@...il.com> wrote:
> 
> Kernel test robot throws below warning -
> 
>>> fs/nfsd/nfs3xdr.c:299:6: warning: variable 'err' is used
>>> uninitialized whenever 'if' condition is false
>>> [-Wsometimes-uninitialized]
>           if (!v4 || !inode->i_sb->s_export_op->fetch_iversion)
>               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>   fs/nfsd/nfs3xdr.c:304:6: note: uninitialized use occurs here
>           if (err) {
>               ^~~
>   fs/nfsd/nfs3xdr.c:299:2: note: remove the 'if' if its condition is
> always true
>           if (!v4 || !inode->i_sb->s_export_op->fetch_iversion)
>           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>   fs/nfsd/nfs3xdr.c:293:12: note: initialize the variable 'err' to
> silence this warning
>           __be32 err;
>                     ^
>                      = 0
>   1 warning generated.
> 
> Initialize err = 0 to silence this warning.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Souptick Joarder <jrdr.linux@...il.com>
> ---
> fs/nfsd/nfs3xdr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/nfsd/nfs3xdr.c b/fs/nfsd/nfs3xdr.c
> index abb1608..47aeaee 100644
> --- a/fs/nfsd/nfs3xdr.c
> +++ b/fs/nfsd/nfs3xdr.c
> @@ -290,7 +290,7 @@ void fill_post_wcc(struct svc_fh *fhp)
> {
> 	bool v4 = (fhp->fh_maxsize == NFS4_FHSIZE);
> 	struct inode *inode = d_inode(fhp->fh_dentry);
> -	__be32 err;
> +	__be32 err = 0;
> 
> 	if (fhp->fh_post_saved)
> 		printk("nfsd: inode locked twice during operation.\n");
> -- 
> 1.9.1
> 

--
Chuck Lever