linux-kernel - Re: [PATCH v2] ttyprintk: optimize tpk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201128063313.GA31258@mi-OptiPlex-7050>
Date:   Sat, 28 Nov 2020 14:33:13 +0800
From:   sunjunyong <sunjy516@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     arnd@...db.de, sunjunyong@...omi.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ttyprintk: optimize tpk_close flush code

Hi Greg:

Sorry for the late reply.
> Why did you not make the change to tpk_printk() as well that I asked you
> to?
> 
> It is a static function, you control the callers, so the extra "is this
> NULL, if so flush" logic makes no sense to keep around anymore, right?
tpk_printk have logic to judge whether the input parameter is NULL.But for
below removed line, we already have known the input parameter is null, so
we don't need call logic of judge NULL, just call tpk_flush to flush is enough.
This is just a little optimization.
----------------------------
-	tpk_printk(NULL, 0);
----------------------------

Brs.
Junyong