linux-kernel - RE: [PATCH] mmc: core: MMC_CAP2_HS200_1_8V_SDR with mmc-hs400-1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR04MB65753FC7EE5058C4A20F6D6FFCF60@DM6PR04MB6575.namprd04.prod.outlook.com>
Date:   Sun, 29 Nov 2020 12:28:48 +0000
From:   Avri Altman <Avri.Altman@....com>
To:     Chris Ruehl <chris.ruehl@...ys.com.hk>
CC:     Ulf Hansson <ulf.hansson@...aro.org>,
        Michał Mirosław <mirq-linux@...e.qmqm.pl>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        Veerabhadrarao Badiganti <vbadigan@...eaurora.org>,
        Matthias Schiffer <matthias.schiffer@...tq-group.com>,
        Chris Ball <chris@...ntf.net>,
        Seungwon Jeon <tgih.jun@...sung.com>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] mmc: core: MMC_CAP2_HS200_1_8V_SDR with mmc-hs400-1_8v

 
> This patch remove the MMC_CAP2_HS200_1_8V_SDR capacity from
> host->cap2 when the dt property mmc-hs400-1v8 set. It cause
> error and occasionally hang on boot and reboot.
> Board with this issue: rk3399 with SanDisk DG4008 eMMC.
> 
> This patch did not change the mmc-hs400-1_2v host->cap2
> added the MMC_CAP2_HS200_1_2V_SDR.
> 
> Log shows a boot process with a HS400 5.1 capable SanDisk 8G
> with mmc-hs400-1_8v dt property and the MMC_CAP2_HS200_1_8V_SDR
> append to the host->cap2.
> 
> [    1.775721] mmc1: CQHCI version 5.10
> [    1.802342] mmc1: SDHCI controller on fe330000.sdhci [fe330000.sdhci]
> using ADMA
> [    2.007581] mmc1: mmc_select_hs200 failed, error -110
> [    2.007589] mmc1: error -110 whilst initialising MMC card
> [    2.413559] mmc1: mmc_select_hs200 failed, error -110
> [    2.413562] mmc1: error -110 whilst initialising MMC card
> [    3.183343] mmc1: Command Queue Engine enabled
> [    3.183355] mmc1: new HS400 MMC card at address 0001
> [    3.197163] mmcblk1: mmc1:0001 DG4008 7.28 GiB
> [    3.197256] mmcblk1boot0: mmc1:0001 DG4008 partition 1 4.00 MiB
> [    3.197360] mmcblk1boot1: mmc1:0001 DG4008 partition 2 4.00 MiB
> [    3.197479] mmcblk1rpmb: mmc1:0001 DG4008 partition 3 4.00 MiB, chardev
> (242:0)
> 
> after patch applied
> [    1.746691] mmc1: CQHCI version 5.10
> [    1.773316] mmc1: SDHCI controller on fe330000.sdhci [fe330000.sdhci]
> using ADMA
> [    1.858410] mmc1: Command Queue Engine enabled
> [    1.858418] mmc1: new HS400 MMC card at address 0001
> [    1.858897] mmcblk1: mmc1:0001 DG4008 7.28 GiB
> [    1.859002] mmcblk1boot0: mmc1:0001 DG4008 partition 1 4.00 MiB
> [    1.859097] mmcblk1boot1: mmc1:0001 DG4008 partition 2 4.00 MiB
> [    1.859182] mmcblk1rpmb: mmc1:0001 DG4008 partition 3 4.00 MiB, chardev
> (242:0)
> 
> Fixes: c373eb489b27b mmc: core: add DT bindings for eMMC HS400 1.8/1.2V
> 
> Signed-off-by: Chris Ruehl <chris.ruehl@...ys.com.hk>
Acked-by: Avri Altman <avri.altman@....com>