linux-kernel - Re: [PATCH v9 2/7] i3c: master: use i3c_master

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 30 Nov 2020 01:12:02 +0800
From:   kernel test robot <lkp@...el.com>
To:     Parshuram Thombare <pthombar@...ence.com>,
        alexandre.belloni@...tlin.com, slongerbeam@...il.com,
        vitor.soares@...opsys.com
Cc:     kbuild-all@...ts.01.org, linux-i3c@...ts.infradead.org,
        linux-kernel@...r.kernel.org, mparab@...ence.com, praneeth@...com,
        Parshuram Thombare <pthombar@...ence.com>
Subject: Re: [PATCH v9 2/7] i3c: master: use i3c_master_register only for
 main master

Hi Parshuram,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on next-20201127]
[cannot apply to linus/master v5.10-rc5 v5.10-rc4 v5.10-rc3 v5.10-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Parshuram-Thombare/I3C-mastership-handover-support/20201129-222847
base:    6174f05255e65622ff3340257879a4c0f858b0df
config: i386-randconfig-a012-20201129 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/963007469aa0a76446a899aa8b019802dfc82cb6
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Parshuram-Thombare/I3C-mastership-handover-support/20201129-222847
        git checkout 963007469aa0a76446a899aa8b019802dfc82cb6
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/i3c/master/mipi-i3c-hci/core.c: In function 'i3c_hci_probe':
>> drivers/i3c/master/mipi-i3c-hci/core.c:760:8: error: implicit declaration of function 'i3c_master_register'; did you mean 'i3c_master_unregister'? [-Werror=implicit-function-declaration]
     760 |  ret = i3c_master_register(&hci->master, &pdev->dev,
         |        ^~~~~~~~~~~~~~~~~~~
         |        i3c_master_unregister
   cc1: some warnings being treated as errors

vim +760 drivers/i3c/master/mipi-i3c-hci/core.c

9ad9a52cce2828d Nicolas Pitre 2020-11-11  733  
9ad9a52cce2828d Nicolas Pitre 2020-11-11  734  static int i3c_hci_probe(struct platform_device *pdev)
9ad9a52cce2828d Nicolas Pitre 2020-11-11  735  {
9ad9a52cce2828d Nicolas Pitre 2020-11-11  736  	struct i3c_hci *hci;
9ad9a52cce2828d Nicolas Pitre 2020-11-11  737  	int irq, ret;
9ad9a52cce2828d Nicolas Pitre 2020-11-11  738  
9ad9a52cce2828d Nicolas Pitre 2020-11-11  739  	hci = devm_kzalloc(&pdev->dev, sizeof(*hci), GFP_KERNEL);
9ad9a52cce2828d Nicolas Pitre 2020-11-11  740  	if (!hci)
9ad9a52cce2828d Nicolas Pitre 2020-11-11  741  		return -ENOMEM;
9ad9a52cce2828d Nicolas Pitre 2020-11-11  742  	hci->base_regs = devm_platform_ioremap_resource(pdev, 0);
9ad9a52cce2828d Nicolas Pitre 2020-11-11  743  	if (IS_ERR(hci->base_regs))
9ad9a52cce2828d Nicolas Pitre 2020-11-11  744  		return PTR_ERR(hci->base_regs);
9ad9a52cce2828d Nicolas Pitre 2020-11-11  745  
9ad9a52cce2828d Nicolas Pitre 2020-11-11  746  	platform_set_drvdata(pdev, hci);
9ad9a52cce2828d Nicolas Pitre 2020-11-11  747  	/* temporary for dev_printk's, to be replaced in i3c_master_register */
9ad9a52cce2828d Nicolas Pitre 2020-11-11  748  	hci->master.dev.init_name = dev_name(&pdev->dev);
9ad9a52cce2828d Nicolas Pitre 2020-11-11  749  
9ad9a52cce2828d Nicolas Pitre 2020-11-11  750  	ret = i3c_hci_init(hci);
9ad9a52cce2828d Nicolas Pitre 2020-11-11  751  	if (ret)
9ad9a52cce2828d Nicolas Pitre 2020-11-11  752  		return ret;
9ad9a52cce2828d Nicolas Pitre 2020-11-11  753  
9ad9a52cce2828d Nicolas Pitre 2020-11-11  754  	irq = platform_get_irq(pdev, 0);
9ad9a52cce2828d Nicolas Pitre 2020-11-11  755  	ret = devm_request_irq(&pdev->dev, irq, i3c_hci_irq_handler,
9ad9a52cce2828d Nicolas Pitre 2020-11-11  756  			       0, NULL, hci);
9ad9a52cce2828d Nicolas Pitre 2020-11-11  757  	if (ret)
9ad9a52cce2828d Nicolas Pitre 2020-11-11  758  		return ret;
9ad9a52cce2828d Nicolas Pitre 2020-11-11  759  
9ad9a52cce2828d Nicolas Pitre 2020-11-11 @760  	ret = i3c_master_register(&hci->master, &pdev->dev,
9ad9a52cce2828d Nicolas Pitre 2020-11-11  761  				  &i3c_hci_ops, false);
9ad9a52cce2828d Nicolas Pitre 2020-11-11  762  	if (ret)
9ad9a52cce2828d Nicolas Pitre 2020-11-11  763  		return ret;
9ad9a52cce2828d Nicolas Pitre 2020-11-11  764  
9ad9a52cce2828d Nicolas Pitre 2020-11-11  765  	return 0;
9ad9a52cce2828d Nicolas Pitre 2020-11-11  766  }
9ad9a52cce2828d Nicolas Pitre 2020-11-11  767  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (30185 bytes)