linux-kernel - Re: [PATCH 11/13] dt-bindings: cpufreq: Convert qcom-cpufreq-hw to YAML binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9fc67c3f-4753-fe4f-ca1b-7faeee2abe7d@somainline.org>
Date:   Mon, 30 Nov 2020 19:23:20 +0100
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...ainline.org>
To:     Rob Herring <robh@...nel.org>
Cc:     viresh.kumar@...aro.org, rjw@...ysocki.net,
        jorge.ramirez-ortiz@...aro.org, robh+dt@...nel.org,
        konrad.dybcio@...ainline.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, ulf.hansson@...aro.org,
        nks@...wful.org, lgirdwood@...il.com, daniel.lezcano@...aro.org,
        devicetree@...r.kernel.org, bjorn.andersson@...aro.org,
        phone-devel@...r.kernel.org, broonie@...nel.org,
        linux-arm-msm@...r.kernel.org, agross@...nel.org,
        marijn.suijten@...ainline.org, martin.botka@...ainline.org
Subject: Re: [PATCH 11/13] dt-bindings: cpufreq: Convert qcom-cpufreq-hw to
 YAML binding

Il 30/11/20 18:23, Rob Herring ha scritto:
> On Thu, 26 Nov 2020 19:45:57 +0100, AngeloGioacchino Del Regno wrote:
>> Convert the qcom-cpufreq-hw documentation to YAML binding as
>> qcom,cpufreq-hw.yaml.
>>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...ainline.org>
>> ---
>>   .../bindings/cpufreq/cpufreq-qcom-hw.txt      | 173 +---------------
>>   .../bindings/cpufreq/qcom,cpufreq-hw.yaml     | 196 ++++++++++++++++++
>>   2 files changed, 197 insertions(+), 172 deletions(-)
>>   create mode 100644 Documentation/devicetree/bindings/cpufreq/qcom,cpufreq-hw.yaml
>>
> 
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/cpufreq/qcom,cpufreq-hw.yaml: properties:clock-names: [{'const': 'xo'}, {'const': 'ref'}] is not of type 'object', 'boolean'
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/cpufreq/qcom,cpufreq-hw.yaml: maintainers:0: 'TBD' is not a 'email'
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/cpufreq/qcom,cpufreq-hw.yaml: ignoring, error in schema: properties: clock-names
> warning: no schema found in file: ./Documentation/devicetree/bindings/cpufreq/qcom,cpufreq-hw.yaml
> Error: Documentation/devicetree/bindings/cpufreq/qcom,cpufreq-hw.example.dts:150.3-151.1 syntax error
> FATAL ERROR: Unable to parse input tree
> make[1]: *** [scripts/Makefile.lib:342: Documentation/devicetree/bindings/cpufreq/qcom,cpufreq-hw.example.dt.yaml] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make: *** [Makefile:1364: dt_binding_check] Error 2
> 
> 
> See https://patchwork.ozlabs.org/patch/1406857
> 
> The base for the patch is generally the last rc1. Any dependencies
> should be noted.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit.
> 

Hello!
All the errors that you've pointed out have been fixed on both the CPR,
CPR3 and cpufreq-hw, but before pushing a V2 of this patch series...

Well, I have a question: the qcom-cpufreq-hw driver has no MAINTAINERS
entry and there was no maintainer for this driver specified in the old
txt format binding.

What should I write in the "maintainers" field of the YAML binding for
this driver?
Should I assign it to the subsystem maintainer?

Thanks,
- Angelo