linux-kernel - Re: [PATCH] x86/e820: fix the function type for e820__mapped

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABCJKucov9YMHn+QD8f-qk2=Oxh=j=DdZJcwHynTefY=zy03aw@mail.gmail.com>
Date:   Mon, 30 Nov 2020 11:16:24 -0800
From:   Sami Tolvanen <samitolvanen@...gle.com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        Kees Cook <keescook@...omium.org>, X86 ML <x86@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Sedat Dilek <sedat.dilek@...il.com>
Subject: Re: [PATCH] x86/e820: fix the function type for e820__mapped_all

On Fri, Nov 27, 2020 at 4:15 AM Borislav Petkov <bp@...en8.de> wrote:
> I think the proper fix is to fix the typedef to:
>
>         typedef bool (*check_reserved_t)(u64 start, u64 end, enum e820_type type);
>
> because
>
> * is_mmconf_reserved() is passing in E820_TYPE_RESERVED which is enum e820_type
>
> * is_acpi_reserved() is the other check_reserved_t function ptr and the last arg
> type there is unused so it can just as well be enum e820_type.

Sure, sounds good. I'll send out v3 to change the type argument to
enum e820_type.

Sami