linux-kernel - Re: [BUG] SPI broken for SPI based panel drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGngYiUuihD5yK9tD6kvetrmwbTcC-cwoYASc5N5P2tct3B2DA@mail.gmail.com>
Date:   Mon, 30 Nov 2020 15:22:41 -0500
From:   Sven Van Asbroeck <thesven73@...il.com>
To:     "H. Nikolaus Schaller" <hns@...delico.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Mark Brown <broonie@...nel.org>,
        kernel list <linux-kernel@...r.kernel.org>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Discussions about the Letux Kernel 
        <letux-kernel@...nphoenux.org>
Subject: Re: [BUG] SPI broken for SPI based panel drivers

And probably also:

@@ -226,8 +226,7 @@ static int spi_gpio_setup(struct spi_device *spi)
        if (spi_gpio->cs_gpios) {
                cs = spi_gpio->cs_gpios[spi->chip_select];
                if (!spi->controller_state && cs)
-                       status = gpiod_direction_output(cs,
-                                                 !(spi->mode & SPI_CS_HIGH));
+                       status = gpiod_direction_output(cs, false);
        }

        if (!status)