linux-kernel - RE: [PATCH] platform/x86: dell-smbios-base: Fix error return code in dell_smbios

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR19MB26363C4F46BFBF973298F7E8FAF50@DM6PR19MB2636.namprd19.prod.outlook.com>
Date:   Mon, 30 Nov 2020 21:50:12 +0000
From:   "Limonciello, Mario" <Mario.Limonciello@...l.com>
To:     Hans de Goede <hdegoede@...hat.com>,
        Qinglang Miao <miaoqinglang@...wei.com>,
        Mark Gross <mgross@...ux.intel.com>
CC:     "platform-driver-x86@...r.kernel.org" 
        <platform-driver-x86@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] platform/x86: dell-smbios-base: Fix error return code in
 dell_smbios_init

> 
> Hi,
> 
> +Cc Mario
> 
> On 11/25/20 7:50 AM, Qinglang Miao wrote:
> > Fix to return the error code -ENODEV when fails to init wmi and
> > smm.
> >
> > Fixes: 41e36f2f85af ("platform/x86: dell-smbios: Link all dell-smbios-*
> modules together")
> > Reported-by: Hulk Robot <hulkci@...wei.com>
> > Signed-off-by: Qinglang Miao <miaoqinglang@...wei.com>
> 
> Mario, this seems like a trivial fix to me, but I'm not 100% sure, any
> comments on this?
> 
> Regards,
> 
> Hans

Yeah, it's reasonable to me.

Reviewed-by: Mario Limonciello <mario.limonciello@...l.com>

> 
> 
> > ---
> >  drivers/platform/x86/dell-smbios-base.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/platform/x86/dell-smbios-base.c
> b/drivers/platform/x86/dell-smbios-base.c
> > index 2e2cd5659..3a1dbf199 100644
> > --- a/drivers/platform/x86/dell-smbios-base.c
> > +++ b/drivers/platform/x86/dell-smbios-base.c
> > @@ -594,6 +594,7 @@ static int __init dell_smbios_init(void)
> >  	if (wmi && smm) {
> >  		pr_err("No SMBIOS backends available (wmi: %d, smm: %d)\n",
> >  			wmi, smm);
> > +		ret = -ENODEV;
> >  		goto fail_create_group;
> >  	}
> >
> >