linux-kernel - Re: [PATCH] ASoC: adau1372: add missing dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201130215710.GV1296649@piout.net>
Date:   Mon, 30 Nov 2020 22:57:10 +0100
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     Liam Girdwood <lgirdwood@...il.com>, alsa-devel@...a-project.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: adau1372: add missing dependencies

On 30/11/2020 22:56:26+0100, Alexandre Belloni wrote:
> SND_SOC_ADAU1372_I2C and SND_SOC_ADAU1372_SPI prpoerly select the REGMAP
> config they need but forget to depend on the underlying bus.
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@...tlin.com>

I forgot:

Reported-by: kernel test robot <lkp@...el.com>

> ---
>  sound/soc/codecs/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> index a457300f95da..625f762903ea 100644
> --- a/sound/soc/codecs/Kconfig
> +++ b/sound/soc/codecs/Kconfig
> @@ -371,11 +371,13 @@ config SND_SOC_ADAU1372
>  
>  config SND_SOC_ADAU1372_I2C
>  	tristate "Analog Devices ADAU1372 CODEC (I2C)"
> +	depends on I2C
>  	select SND_SOC_ADAU1372
>  	select REGMAP_I2C
>  
>  config SND_SOC_ADAU1372_SPI
>  	tristate "Analog Devices ADAU1372 CODEC (SPI)"
> +	depends on SPI
>  	select SND_SOC_ADAU1372
>  	select REGMAP_SPI
>  
> -- 
> 2.28.0
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com