lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 30 Nov 2020 17:09:41 -0500 From: Alex Deucher <alexdeucher@...il.com> To: Lee Jones <lee.jones@...aro.org> Cc: Zhigang Luo <zhigang.luo@....com>, David Airlie <airlied@...ux.ie>, LKML <linux-kernel@...r.kernel.org>, amd-gfx list <amd-gfx@...ts.freedesktop.org>, Maling list - DRI developers <dri-devel@...ts.freedesktop.org>, Alex Deucher <alexander.deucher@....com>, Christian König <christian.koenig@....com> Subject: Re: [PATCH 09/40] drm/amd/amdgpu/vega10_ih: Add descriptions for 'ih' and 'entry' On Tue, Nov 24, 2020 at 2:44 PM Lee Jones <lee.jones@...aro.org> wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/vega10_ih.c:377: warning: Function parameter or member 'ih' not described in 'vega10_ih_get_wptr' > drivers/gpu/drm/amd/amdgpu/vega10_ih.c:440: warning: Function parameter or member 'ih' not described in 'vega10_ih_decode_iv' > drivers/gpu/drm/amd/amdgpu/vega10_ih.c:440: warning: Function parameter or member 'entry' not described in 'vega10_ih_decode_iv' > drivers/gpu/drm/amd/amdgpu/vega10_ih.c:480: warning: Function parameter or member 'ih' not described in 'vega10_ih_irq_rearm' > drivers/gpu/drm/amd/amdgpu/vega10_ih.c:513: warning: Function parameter or member 'ih' not described in 'vega10_ih_set_rptr' > > Cc: Alex Deucher <alexander.deucher@....com> > Cc: "Christian König" <christian.koenig@....com> > Cc: David Airlie <airlied@...ux.ie> > Cc: Daniel Vetter <daniel@...ll.ch> > Cc: Zhigang Luo <zhigang.luo@....com> > Cc: amd-gfx@...ts.freedesktop.org > Cc: dri-devel@...ts.freedesktop.org > Signed-off-by: Lee Jones <lee.jones@...aro.org> Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/vega10_ih.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/vega10_ih.c b/drivers/gpu/drm/amd/amdgpu/vega10_ih.c > index 407c6093c2ec0..578fdee5b9758 100644 > --- a/drivers/gpu/drm/amd/amdgpu/vega10_ih.c > +++ b/drivers/gpu/drm/amd/amdgpu/vega10_ih.c > @@ -366,6 +366,7 @@ static void vega10_ih_irq_disable(struct amdgpu_device *adev) > * vega10_ih_get_wptr - get the IH ring buffer wptr > * > * @adev: amdgpu_device pointer > + * @ih: IH ring buffer to fetch wptr > * > * Get the IH ring buffer wptr from either the register > * or the writeback memory buffer (VEGA10). Also check for > @@ -430,6 +431,8 @@ static u32 vega10_ih_get_wptr(struct amdgpu_device *adev, > * vega10_ih_decode_iv - decode an interrupt vector > * > * @adev: amdgpu_device pointer > + * @ih: IH ring buffer to decode > + * @entry: IV entry to place decoded information into > * > * Decodes the interrupt vector at the current rptr > * position and also advance the position. > @@ -473,6 +476,7 @@ static void vega10_ih_decode_iv(struct amdgpu_device *adev, > * vega10_ih_irq_rearm - rearm IRQ if lost > * > * @adev: amdgpu_device pointer > + * @ih: IH ring to match > * > */ > static void vega10_ih_irq_rearm(struct amdgpu_device *adev, > @@ -505,6 +509,7 @@ static void vega10_ih_irq_rearm(struct amdgpu_device *adev, > * vega10_ih_set_rptr - set the IH ring buffer rptr > * > * @adev: amdgpu_device pointer > + * @ih: IH ring buffer to set rptr > * > * Set the IH ring buffer rptr. > */ > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@...ts.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
Powered by blists - more mailing lists